AB#115039 disable AWS lookup in local config#207
Closed
lardo-de-arnaud wants to merge 1 commit intomasterfrom
Closed
AB#115039 disable AWS lookup in local config#207lardo-de-arnaud wants to merge 1 commit intomasterfrom
lardo-de-arnaud wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Disables AWS Secrets Manager lookup in the local SSL configuration profile to avoid AWS lookups when testing locally.
Changes:
- Added
spring.cloud.aws.secretsmanager.enabled=falseto the local SSL properties file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
buckett
reviewed
Mar 16, 2026
| server.servlet.session.cookie.secure=true | ||
|
|
||
| # Disable the secrets manager as we don't have any secrets in AWS when testing. | ||
| spring.cloud.aws.secretsmanager.enabled=false No newline at end of file |
Member
There was a problem hiding this comment.
I wouldn't have put this here as it's completely unrelated to running tool support with SSL enabled. The common pattern is to disable it by default and then enable it when in AWS.
Contributor
Author
|
lin has been added to the wrong file so dumping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.