Fix ConnectionPool.get() race condition#15
Merged
merlimat merged 1 commit intooxia-db:mainfrom Apr 16, 2026
Merged
Conversation
ConnectionPool.get() had no locking — concurrent callers could both see a cache miss and create duplicate gRPC channels, leaking all but one. close() also did not clear the pool, allowing stale stubs to be returned after close. Fix: wrap get() and close() with a threading.Lock. close() now clears the connections dict after closing channels. Signed-off-by: Matteo Merli <mmerli@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get() had no locking — concurrent callers could both miss the cache and create duplicate gRPC channels, leaking all but one. close() didn't clear the pool either.
Fix: wrap get() and close() with a threading.Lock. close() now clears the connections dict.