feat: use shared test files and update snapshots#17
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces shared test files infrastructure and updates snapshots for DBC parsing tests. The primary purpose is to consolidate test resources by using a shared test files submodule while maintaining backwards compatibility with existing local test files.
Key changes:
- Implement a snapshot-based testing framework using the
instacrate - Add support for testing DBC files from both shared and local directories
- Generate comprehensive YAML snapshots for parsed DBC structures
Reviewed Changes
Copilot reviewed 89 out of 167 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/snapshots.rs | New test infrastructure that parses DBC files and generates snapshots from multiple directories |
| tests/snapshots-mytest/*.snap | YAML snapshots for local test DBC files in the mytest directory |
| tests/snapshots-dbc-cantools/*.snap | YAML snapshots for shared cantools DBC test files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c320943 to
549e60d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
* Note that long_names.dbc has been modified upstream, so I copied the original to the `mytest` dir. * In the next PR, I will remove the dbc/dbc-cantools
549e60d to
8ee5215
Compare
|
@MDGSF thank you for reviewing! It's ok not to merge my PRs because I have the rights to do it. It is better to let me do it - because I may spot additional issues right before merging. |
## 🤖 New release * `rrdbc`: 0.2.0 -> 0.2.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.2.1](v0.2.0...v0.2.1) - 2025-10-08 ### Added - use shared test files and update snapshots ([#17](#17)) - add `decode_cp1252` and snapshot tests ([#16](#16)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
This PR includes #16 - make sure to merge it first
mytestdir.