Skip to content

feat: use shared test files and update snapshots#17

Merged
nyurik merged 1 commit intooxibus:mainfrom
nyurik:shared-snapshots
Oct 8, 2025
Merged

feat: use shared test files and update snapshots#17
nyurik merged 1 commit intooxibus:mainfrom
nyurik:shared-snapshots

Conversation

@nyurik
Copy link
Copy Markdown
Member

@nyurik nyurik commented Oct 5, 2025

This PR includes #16 - make sure to merge it first

  • Note that long_names.dbc has been modified upstream, so I copied the original to the mytest dir.
  • In the next PR, I will remove the dbc/dbc-cantools

Copilot AI review requested due to automatic review settings October 5, 2025 05:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces shared test files infrastructure and updates snapshots for DBC parsing tests. The primary purpose is to consolidate test resources by using a shared test files submodule while maintaining backwards compatibility with existing local test files.

Key changes:

  • Implement a snapshot-based testing framework using the insta crate
  • Add support for testing DBC files from both shared and local directories
  • Generate comprehensive YAML snapshots for parsed DBC structures

Reviewed Changes

Copilot reviewed 89 out of 167 changed files in this pull request and generated 1 comment.

File Description
tests/snapshots.rs New test infrastructure that parses DBC files and generates snapshots from multiple directories
tests/snapshots-mytest/*.snap YAML snapshots for local test DBC files in the mytest directory
tests/snapshots-dbc-cantools/*.snap YAML snapshots for shared cantools DBC test files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@MDGSF MDGSF enabled auto-merge (squash) October 8, 2025 01:44
* Note that long_names.dbc has been modified upstream, so I copied the original to the `mytest` dir.
* In the next PR, I will remove the dbc/dbc-cantools
@nyurik nyurik disabled auto-merge October 8, 2025 01:45
@nyurik
Copy link
Copy Markdown
Member Author

nyurik commented Oct 8, 2025

@MDGSF thank you for reviewing! It's ok not to merge my PRs because I have the rights to do it. It is better to let me do it - because I may spot additional issues right before merging.

@nyurik nyurik merged commit 662a82e into oxibus:main Oct 8, 2025
8 checks passed
@nyurik nyurik deleted the shared-snapshots branch October 8, 2025 01:48
nyurik added a commit that referenced this pull request Oct 8, 2025
## 🤖 New release

* `rrdbc`: 0.2.0 -> 0.2.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.2.1](v0.2.0...v0.2.1) -
2025-10-08

### Added

- use shared test files and update snapshots
([#17](#17))
- add `decode_cp1252` and snapshot tests
([#16](#16))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants