Fix double error toasts (#3167)

All of these mutations get confirmed and therefore have their error
toasts handled by the `catch` in `ConfirmActionModal`. Using an
`onError` means they get two toasts. Thanks @jordanhendricks for
reporting this.


https://github.com/oxidecomputer/console/blob/c53101e2cbd76bf41cfd8e0e39c1adf688be8e58/app/components/ConfirmActionModal.tsx#L36-L44

I am working on some zany schemes for avoiding this in the future, but
in the meantime let's at least fix these.

Author: david-crespo

app/pages/project/floating-ips/FloatingIpsPage.tsx

@@ -118,9 +118,6 @@ export default function FloatingIpsPage() {
       // prettier-ignore
       addToast(<>Floating IP <HL>{floatingIp.name}</HL> detached</>)
     },
-    onError: (err) => {
-      addToast({ title: 'Error', content: err.message, variant: 'error' })
-    },
   })
   const { mutateAsync: deleteFloatingIp } = useApiMutation(api.floatingIpDelete, {
     onSuccess(_data, variables) {

app/pages/project/instances/NetworkingTab.tsx

@@ -479,9 +479,6 @@ export default function NetworkingTab() {
       queryClient.invalidateEndpoint('instanceExternalIpList')
       addToast({ content: 'Ephemeral IP detached' })
     },
-    onError: (err) => {
-      addToast({ title: 'Error', content: err.message, variant: 'error' })
-    },
   })
 
   const { mutateAsync: floatingIpDetach } = useApiMutation(api.floatingIpDetach, {
@@ -491,9 +488,6 @@ export default function NetworkingTab() {
       // prettier-ignore
       addToast(<>Floating IP <HL>{variables.path.floatingIp}</HL> detached</>)
     },
-    onError: (err) => {
-      addToast({ title: 'Error', content: err.message, variant: 'error' })
-    },
   })
 
   const { mutateAsync: externalSubnetDetach } = useApiMutation(api.externalSubnetDetach, {

app/pages/project/instances/StorageTab.tsx

@@ -113,9 +113,6 @@ export default function StorageTab() {
       // prettier-ignore
       addToast(<>Disk <HL>{disk.name}</HL> detached</>)
     },
-    onError(err) {
-      addToast({ title: 'Failed to detach disk', content: err.message, variant: 'error' })
-    },
   })
   const { mutate: createSnapshot } = useApiMutation(api.snapshotCreate, {
     onSuccess(snapshot) {

app/pages/project/instances/actions.tsx

@@ -63,20 +63,14 @@ export const useMakeInstanceActions = (
                 startInstanceAsync(instanceParams, {
                   // prettier-ignore
                   onSuccess: () => addToast(<>Starting instance <HL>{instance.name}</HL></>),
-                  onError: (error) =>
-                    addToast({
-                      variant: 'error',
-                      title: `Error starting instance '${instance.name}'`,
-                      content: error.message,
-                    }),
                 }),
               modalTitle: 'Confirm start instance',
               modalContent: (
                 <p>
                   Are you sure you want to start <HL>{instance.name}</HL>?
                 </p>
               ),
-              errorTitle: `Error starting ${instance.name}`,
+              errorTitle: `Error starting instance '${instance.name}'`,
             })
           },
           disabled: !instanceCan.start(instance) && (