Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7014997 to
2376ef0
Compare
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 3, 2026
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of these mutations get confirmed and therefore have their error toasts handled by the
catchinConfirmActionModal. Using anonErrormeans they get two toasts. Thanks @jordanhendricks for reporting this.console/app/components/ConfirmActionModal.tsx
Lines 36 to 44 in c53101e
I am working on some zany schemes for avoiding this in the future, but in the meantime let's at least fix these.