`instance-create.tsx`: button inconsistency

[sudomateo]

I was using the instance-create.tsx form to create an instance when I noticed the buttons for disks, SSH keys, and floating IPs are all inconsistent with one another. We should consider making all these buttons consistent so it's clear they can be clicked to perform the desired action. I would suggest making them all use the primary variant, but perhaps that would conflict with the "Create instance" button that's on the bottom of the entire form. Either way, I think some consistency would be good here.

Reference

The disks section uses two buttons, the variants are primary and secondary.

The SSH keys section uses a single button with the ghost variant.

The floating IPs section uses a single button with the secondary variant.

This is just close enough visually to a disabled button, which confused me for a bit because I thought I couldn't click the button even though I had valid floating IPs available.

[david-crespo]

I think the primary/secondary thing is deliberate. We use primary for actions that create things. At the very least we’ll want to make the SSH keys button secondary to match the other two. But it’s good feedback that the secondary button looks disabled. Maybe we can make the border and text a little stronger.

[david-crespo]

Just realized by my logic the SSH key one would be primary. But I don’t think it would look right.

[sudomateo]

At first I figured they all should be primary, but I believe that would compete with the final button on the form at the end. I made this an issue instead of a pull request because I wanted to defer to you and Ben on what design changes would be best here.

This is also a concern in dark mode by the way, I just captured screen shots in light mode.