Turn metrics back on #1330
Merged
Turn metrics back on #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Metrics design improvements - Area chart -> Line chart - Shorter day format for same day metrics - Tweak colours - Tweak spacing - Wrapper with border - Separating/styling title and unit * Round the tooltip corners * Cleanup * Unify props for both charts * Add elevation to tooltip * Tweak chart padding and height
david-crespo
force-pushed
the
metrics-again
branch
from
d1377a3 to
b0a21c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly uncommenting or redoing stuff that was already here from #1214. This PR includes:
Note on code splitting
We were doing code splitting by dynamically importing page components for pages with large libraries (in this case Recharts). When there was only one (the instance metrics tab) this had a reasonable result: a decent-sized
MetricsTab.jsfile split out from the mainapp.jsHowever, it turns out Vite is smarter than I thought, and once I added two more pages using Recharts, we got this: Vite knows all the pages have
TimeSeriesChartin common, so it automatically extracts that into its own separate file, leaving all the page-specific files very small, like 1-2 KB. There's no point in having separate files for them if they're small!So, I changed it so the pages are regular imports and inside they import
TimeSeriesChartdynamically, which means onlyTimeSeriesChartgets its own file.