Metrics design touchup #1331
Merged
Metrics design touchup #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Area chart -> Line chart - Shorter day format for same day metrics - Tweak colours - Tweak spacing - Wrapper with border - Separating/styling title and unit
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
Beautiful. Will merge and see if I need to tweak the implementation in the other PR. |
Merged
david-crespo
added a commit
that referenced
this pull request
Jan 20, 2023
* kinda do something * Metrics design touchup (#1331) * Metrics design improvements - Area chart -> Line chart - Shorter day format for same day metrics - Tweak colours - Tweak spacing - Wrapper with border - Separating/styling title and unit * Round the tooltip corners * Cleanup * Unify props for both charts * Add elevation to tooltip * Tweak chart padding and height * turns out that in order to show the data, you have to fetch the data * get rid of customXTicks prop, make it always custom * code split silo and system utilization pages * make TimeSeriesChart the only dynamic import * prefetch disks list for instance metrics tab Co-authored-by: Benjamin Leonard <benji@oxide.computer>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick pass to get more or less parity with the designs. There's more work to do, but lets tackle that when we have more metric endpoints and real data to test with. I've made a dupe component, since the disk metrics are a line chart not an area one. I'll defer to you on how we best style and configure those components without repeating ourselves too much.