Change close button on modal to absolute positioned have correct tab order#1715
Merged
just-be-dev merged 2 commits intomainfrom Aug 8, 2023
Merged
Change close button on modal to absolute positioned have correct tab order#1715just-be-dev merged 2 commits intomainfrom
just-be-dev merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Just tweaked it — there's some extra spacing because of the hover state and the increased click area. This now matches the previous version. LGTM Thanks! |
| </Dialog.Title> | ||
| )} | ||
| {children} | ||
| <Dialog.Close |
Contributor
There was a problem hiding this comment.
We might want to add a comment for context like the side modal — in case this component is recreated and we hit the same issue again.
benjaminleonard
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1714