Skip to content

Sleep after closing toast in E2E to reduce flake #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Dec 4, 2023
Merged

Sleep after closing toast in E2E to reduce flake #1832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/test/e2e/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,10 @@ export async function expectRowVisible(
export async function stopInstance(page: Page) {
await page.click('role=button[name="Instance actions"]')
await page.click('role=menuitem[name="Stop"]')
// close toast. for some reason it prevents things from happening
// close toast and wait for it to fade out. for some reason it prevents things
// from working, but only in tests as far as we can tell
await page.click('role=button[name="Dismiss notification"]')
await sleep(2000)
}

/**
Expand Down