Turn off contextual alternates in the terminal #1841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjaminleonard
commented
Dec 8, 2023
| return ( | ||
| <> | ||
| <div className="h-full w-[calc(100%-3rem)]" ref={terminalRef} /> | ||
| <div className="h-full w-[calc(100%-3rem)] text-mono-code" ref={terminalRef} /> |
There was a problem hiding this comment.
Technically the terminal is styled inline with some values passed to xterm.js. By including text-mono-code here it's also adding a bunch of styles that are ignored/overriden by those inline styles, but the font-feature-settings come with it, so it's probably the easiest and best fix here.
david-crespo
approved these changes
Dec 8, 2023
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 14, 2023
oxidecomputer/console@1802c28...007cfe6 * [007cfe67](oxidecomputer/console@007cfe67) oxidecomputer/console#1858 * [d536bd97](oxidecomputer/console@d536bd97) oxidecomputer/console#1857 * [bfd59c0d](oxidecomputer/console@bfd59c0d) oxidecomputer/console#1845 * [ba335d45](oxidecomputer/console@ba335d45) oxidecomputer/console#1853 * [5556d881](oxidecomputer/console@5556d881) update mockServiceWorker.js * [48da3e1c](oxidecomputer/console@48da3e1c) oxidecomputer/console#1841 * [a7532d9a](oxidecomputer/console@a7532d9a) oxidecomputer/console#1842
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 15, 2023
oxidecomputer/console@1802c28...007cfe6 * [007cfe67](oxidecomputer/console@007cfe67) oxidecomputer/console#1858 * [d536bd97](oxidecomputer/console@d536bd97) oxidecomputer/console#1857 * [bfd59c0d](oxidecomputer/console@bfd59c0d) oxidecomputer/console#1845 * [ba335d45](oxidecomputer/console@ba335d45) oxidecomputer/console#1853 * [5556d881](oxidecomputer/console@5556d881) update mockServiceWorker.js * [48da3e1c](oxidecomputer/console@48da3e1c) oxidecomputer/console#1841 * [a7532d9a](oxidecomputer/console@a7532d9a) oxidecomputer/console#1842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1840
Context – many years ago when we cut a new version of the typeface, we (I) thought it might be cute to include the contextual alternate so that "Oxide" or "Ox" would look more brand-like when typed in the console. It's not cute, it's stupid, and that's my cross to bear.
This fixes the issue through an update to the type styles in
@oxide/design-system. I've also merged in the stylistic sets we're using for the ASCII diagrams on the website, but these don't interfere with regular usage.