Move CopyToClipboard to its own component #1845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I want to look at some accessibility affordances we might add to the button / test it out with a screenreader. Will update tomorrow when ready for review. |
charliepark
commented
Dec 11, 2023
| className="text-tertiary hover:text-accent-secondary" | ||
| onClick={handleCopy} | ||
| type="button" | ||
| aria-label={hasCopied ? 'Copied' : ariaLabel} |
There was a problem hiding this comment.
Tested this with VoiceOver on Mac, and it reads the appropriate text in the appropriate state, and live-updates when it changes.
zephraph
approved these changes
Dec 11, 2023
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 14, 2023
oxidecomputer/console@1802c28...007cfe6 * [007cfe67](oxidecomputer/console@007cfe67) oxidecomputer/console#1858 * [d536bd97](oxidecomputer/console@d536bd97) oxidecomputer/console#1857 * [bfd59c0d](oxidecomputer/console@bfd59c0d) oxidecomputer/console#1845 * [ba335d45](oxidecomputer/console@ba335d45) oxidecomputer/console#1853 * [5556d881](oxidecomputer/console@5556d881) update mockServiceWorker.js * [48da3e1c](oxidecomputer/console@48da3e1c) oxidecomputer/console#1841 * [a7532d9a](oxidecomputer/console@a7532d9a) oxidecomputer/console#1842
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 15, 2023
oxidecomputer/console@1802c28...007cfe6 * [007cfe67](oxidecomputer/console@007cfe67) oxidecomputer/console#1858 * [d536bd97](oxidecomputer/console@d536bd97) oxidecomputer/console#1857 * [bfd59c0d](oxidecomputer/console@bfd59c0d) oxidecomputer/console#1845 * [ba335d45](oxidecomputer/console@ba335d45) oxidecomputer/console#1853 * [5556d881](oxidecomputer/console@5556d881) update mockServiceWorker.js * [48da3e1c](oxidecomputer/console@48da3e1c) oxidecomputer/console#1841 * [a7532d9a](oxidecomputer/console@a7532d9a) oxidecomputer/console#1842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactor, pulling the CopyToClipboard functionality out of Truncate and into its own component so we can re-use it independently, as needed.
There's no change to the current interaction, but here's a recording of it in situ:
https://github.com/oxidecomputer/console/assets/22547/ea7f7a9a-c0cc-44b5-9d67-1b1b29308dfb
[Eh; thought that would just embed the .mov. Sorry for the extra step.]