Path builder imageNew -> imagesNew, etc, to match route paths
#2030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Mar 4, 2024
| snapshotImageCreate: (params: Snapshot) => | ||
| `${pb.project(params)}/snapshots/${params.snapshot}/image-new`, | ||
| snapshotImagesNew: (params: Snapshot) => | ||
| `${pb.project(params)}/snapshots/${params.snapshot}/images-new`, |
Collaborator
Author
There was a problem hiding this comment.
On this one (only this one) I actually changed the route too because it was wrong.
david-crespo
commented
Mar 4, 2024
| /> | ||
| <Route | ||
| path="snapshots/:snapshot/image-new" | ||
| path="snapshots/:snapshot/images-new" |
Collaborator
Author
There was a problem hiding this comment.
zero grep results for image-new after changing this
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Mar 6, 2024
oxidecomputer/console@269c2c8...784e8aa * [784e8aac](oxidecomputer/console@784e8aac) oxidecomputer/console#2035 * [da07ce01](oxidecomputer/console@da07ce01) oxidecomputer/console#2039 * [04b56b02](oxidecomputer/console@04b56b02) oxidecomputer/console#2037 * [55a72c86](oxidecomputer/console@55a72c86) oxidecomputer/console#2036 * [f0cf2be5](oxidecomputer/console@f0cf2be5) oxidecomputer/console#2033 * [3ad46af4](oxidecomputer/console@3ad46af4) oxidecomputer/console#2032 * [cd1bff5c](oxidecomputer/console@cd1bff5c) bump playwright and react query and stuff * [08bd3fe5](oxidecomputer/console@08bd3fe5) oxidecomputer/console#2030 * [02701738](oxidecomputer/console@02701738) forgot to delete app/ui/index.ts
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Mar 7, 2024
oxidecomputer/console@269c2c8...784e8aa * [784e8aac](oxidecomputer/console@784e8aac) oxidecomputer/console#2035 * [da07ce01](oxidecomputer/console@da07ce01) oxidecomputer/console#2039 * [04b56b02](oxidecomputer/console@04b56b02) oxidecomputer/console#2037 * [55a72c86](oxidecomputer/console@55a72c86) oxidecomputer/console#2036 * [f0cf2be5](oxidecomputer/console@f0cf2be5) oxidecomputer/console#2033 * [3ad46af4](oxidecomputer/console@3ad46af4) oxidecomputer/console#2032 * [cd1bff5c](oxidecomputer/console@cd1bff5c) bump playwright and react query and stuff * [08bd3fe5](oxidecomputer/console@08bd3fe5) oxidecomputer/console#2030 * [02701738](oxidecomputer/console@02701738) forgot to delete app/ui/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a silly inconsistency I noticed recently.