Skip to content

Add docs popover button to instance create #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2024
Merged

Add docs popover button to instance create #2237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f202070
Add docsPopover prop to FullPageForm, and implementation
charliepark May 10, 2024
94a1af1
Move page header to instance-create
charliepark May 13, 2024
92b45c4
Add link to Quick Start
charliepark May 13, 2024
3f21063
Finish adding Quick Start
charliepark May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions app/components/form/FullPageForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
*
* Copyright Oxide Computer Company
*/
import { cloneElement, useEffect, type ReactElement, type ReactNode } from 'react'
import { cloneElement, useEffect, type ReactNode } from 'react'
import type { FieldValues, UseFormReturn } from 'react-hook-form'
import { useBlocker, type Blocker } from 'react-router-dom'

import type { ApiError } from '@oxide/api'

import { Modal } from '~/ui/lib/Modal'
import { PageHeader, PageTitle } from '~/ui/lib/PageHeader'
import { flattenChildren, pluckFirstOfType } from '~/util/children'
import { classed } from '~/util/classed'

Expand All @@ -21,8 +20,6 @@ import { PageActions } from '../PageActions'

interface FullPageFormProps<TFieldValues extends FieldValues> {
id: string
title: string
icon: ReactElement
/** Must provide a reason for submit being disabled */
submitDisabled?: string
error?: Error
Expand Down Expand Up @@ -50,11 +47,9 @@ const PageActionsContainer = classed.div`flex h-20 items-center gutter`

export function FullPageForm<TFieldValues extends FieldValues>({
id,
title,
children,
submitDisabled,
error,
icon,
loading,
form,
onSubmit,
Expand Down Expand Up @@ -85,9 +80,6 @@ export function FullPageForm<TFieldValues extends FieldValues>({

return (
<>
<PageHeader>
<PageTitle icon={icon}>{title}</PageTitle>
</PageHeader>
<form
className="ox-form pb-20"
id={id}
Expand Down
Loading