update inventory sidebar link

[charliepark]

Fixes #2173

Currently, the sidebar link directs users to /inventory/sleds, which means that the ReactRouter magical isActive prop doesn't know that it should be highlighted for either /inventory/sleds OR /inventory/disks. By changing the route to just /inventory, it matches for both, and so it highlights the sidebar item regardless of which tab they're on.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
console	✅ Ready (Inspect)	Visit Preview	May 10, 2024 11:05pm

[david-crespo]

There are some loader and back button shenanigans that can happen when you link to the parent and rely on the replace nav. I’ll show you Monday how to test it out. If it doesn’t work well we might have to get more clever with the active style logic to match on /inventory while keeping the link to /inventory/sleds.

console/app/routes.tsx

Lines 151 to 160 in efceb17

	<Route
	path="inventory"
	element={<InventoryPage />}
	loader={InventoryPage.loader}
	handle={{ crumb: 'Inventory' }}
	>
	<Route index element={<Navigate to="sleds" replace />} loader={SledsTab.loader} />
	<Route path="sleds" element={<SledsTab />} loader={SledsTab.loader} />
	<Route path="disks" element={<DisksTab />} loader={DisksTab.loader} />
	</Route>

[david-crespo]

Exorcised my worry in #2253. Could not find any issues with this approach. We may want to update some other route tab pages in followup PRs if they have the same problem.