convert silo page tabs to route-based navigation #2912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
IdP form routes need to be nested under the route that displays the tab contents, otherwise it disappears when the side modal is open. Fixed in 6554de5. 
|
|
Worth noting: the IP pool link modal on the IP pools tab and the quota edit side modal on the quotas tab do not need the same nested route treatment because they are not routes. The side modal one probably should be a route, but I'm not going to bother changing that now because Ben is reworking that whole tab anyway. |
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 15, 2025
oxidecomputer/console@36e415c...ee1aa57 * [ee1aa575](oxidecomputer/console@ee1aa575) oxidecomputer/console#2920 * [74c20607](oxidecomputer/console@74c20607) oxidecomputer/console#2915 * [96939d35](oxidecomputer/console@96939d35) oxidecomputer/console#2910 * [1bc51872](oxidecomputer/console@1bc51872) oxidecomputer/console#2917 * [96211e99](oxidecomputer/console@96211e99) oxidecomputer/console#2914 * [22482fc1](oxidecomputer/console@22482fc1) oxidecomputer/console#2912 * [5c393b4d](oxidecomputer/console@5c393b4d) oxidecomputer/console#2911 * [8ac318bb](oxidecomputer/console@8ac318bb) oxidecomputer/console#2742
This was referenced Oct 15, 2025
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 15, 2025
oxidecomputer/console@36e415c...ee1aa57 * [ee1aa575](oxidecomputer/console@ee1aa575) oxidecomputer/console#2920 * [74c20607](oxidecomputer/console@74c20607) oxidecomputer/console#2915 * [96939d35](oxidecomputer/console@96939d35) oxidecomputer/console#2910 * [1bc51872](oxidecomputer/console@1bc51872) oxidecomputer/console#2917 * [96211e99](oxidecomputer/console@96211e99) oxidecomputer/console#2914 * [22482fc1](oxidecomputer/console@22482fc1) oxidecomputer/console#2912 * [5c393b4d](oxidecomputer/console@5c393b4d) oxidecomputer/console#2911 * [8ac318bb](oxidecomputer/console@8ac318bb) oxidecomputer/console#2742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding the SCIM tab to the silo page, I thought it'd be good to update the silo page's tab routing.
/system/silos/maze-war?tab=ip-pools→/system/silos/maze-war/ip-poolsAlso adds a redirect to handle stale links.