-
Notifications
You must be signed in to change notification settings - Fork 13
Tailwind 4 #2910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailwind 4 #2910
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Visual regression script Update generate-visual-baseline.sh Setting up tests Fix cmd Test improvements Add regression e2e test Fix / remove vis regression tests Update generate-visual-baseline.sh Simplify scripts Simplify regression readme
Lots of changes, most due to the formatting. Almost ready to go, I need to go back over it a couple times, but visually it looks like there's parity. Adding a visual regression test that fails on most counts because the table row height has changed slightly due to a little bit of a table tweak as I was fixing some things. The table could probably do with a full refactor, it's split between the css file and inline. It should probably all be in the css file. Would be good to get merged as soon as poss, it touches so many files that the merge conflicts will get painful. |
Found something interesting in the build output.
mainhttps://github.com/oxidecomputer/console/actions/runs/18479011038/job/52649823166#step:8:36 ![]() ![]() 53df521https://github.com/oxidecomputer/console/actions/runs/18503116960/job/52725077386#step:8:359 ![]() ![]() |
Yep, we are somehow pulling in the entirety of asciidoctor through the design system. oxidecomputer/design-system#150 ![]() |
Confirmed we are back to normal with oxidecomputer/design-system#151. Top is main, bottom is 8996191. ![]() |
04f1da6
to
8996191
Compare
Merging as-is with the canary design-system release because I have messed up the releases in the design-system repo real bad. We will update this to stable design-system tomorrow. |
oxidecomputer/console@36e415c...ee1aa57 * [ee1aa575](oxidecomputer/console@ee1aa575) oxidecomputer/console#2920 * [74c20607](oxidecomputer/console@74c20607) oxidecomputer/console#2915 * [96939d35](oxidecomputer/console@96939d35) oxidecomputer/console#2910 * [1bc51872](oxidecomputer/console@1bc51872) oxidecomputer/console#2917 * [96211e99](oxidecomputer/console@96211e99) oxidecomputer/console#2914 * [22482fc1](oxidecomputer/console@22482fc1) oxidecomputer/console#2912 * [5c393b4d](oxidecomputer/console@5c393b4d) oxidecomputer/console#2911 * [8ac318bb](oxidecomputer/console@8ac318bb) oxidecomputer/console#2742
oxidecomputer/console@36e415c...ee1aa57 * [ee1aa575](oxidecomputer/console@ee1aa575) oxidecomputer/console#2920 * [74c20607](oxidecomputer/console@74c20607) oxidecomputer/console#2915 * [96939d35](oxidecomputer/console@96939d35) oxidecomputer/console#2910 * [1bc51872](oxidecomputer/console@1bc51872) oxidecomputer/console#2917 * [96211e99](oxidecomputer/console@96211e99) oxidecomputer/console#2914 * [22482fc1](oxidecomputer/console@22482fc1) oxidecomputer/console#2912 * [5c393b4d](oxidecomputer/console@5c393b4d) oxidecomputer/console#2911 * [8ac318bb](oxidecomputer/console@8ac318bb) oxidecomputer/console#2742
Replaces #2826 — figured it'd be easier to avoid so many merge conflicts.
The lack of a z-index utility is a little clunky here. And still a couple things to fix. Tables and badges are borked.
This is another place where visual regression testing would be particularly useful.