Skip to content

Conversation

benjaminleonard
Copy link
Contributor

@benjaminleonard benjaminleonard commented Oct 9, 2025

Replaces #2826 — figured it'd be easier to avoid so many merge conflicts.

The lack of a z-index utility is a little clunky here. And still a couple things to fix. Tables and badges are borked.
This is another place where visual regression testing would be particularly useful.

  • Fix table styles
  • Fix instance hardware radios
  • Fix focus on dropdown open
  • Fix badge outlines
  • Fix table scrollbar always showing
  • Fix scrollbar when no more actions cell
  • Double check badge padding / size
  • Horizontal scrolling on serial console
  • Weird build output and a lot of it (Tailwind 4 #2910 (comment))

Copy link

vercel bot commented Oct 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
console Ready Ready Preview Oct 14, 2025 10:22pm

Visual regression script

Update generate-visual-baseline.sh

Setting up tests

Fix cmd

Test improvements

Add regression e2e test

Fix / remove vis regression tests

Update generate-visual-baseline.sh

Simplify scripts

Simplify regression readme
@benjaminleonard
Copy link
Contributor Author

Lots of changes, most due to the formatting.

Almost ready to go, I need to go back over it a couple times, but visually it looks like there's parity. Adding a visual regression test that fails on most counts because the table row height has changed slightly due to a little bit of a table tweak as I was fixing some things.

The table could probably do with a full refactor, it's split between the css file and inline. It should probably all be in the css file.

Would be good to get merged as soon as poss, it touches so many files that the merge conflicts will get painful.

@david-crespo
Copy link
Collaborator

Sideways scroll on serial console:

image

@david-crespo
Copy link
Collaborator

david-crespo commented Oct 14, 2025

Found something interesting in the build output.

  • CSS file shrinking by 1/3: good.
  • Generating 323 instead of 99, many of which are huge: not good. Judging from all the programming language names, it seems like we're pulling in some that stuff related to syntax highlighting in AsciiDoc. But I don't know what's going on with TypeValueCell there.

main

https://github.com/oxidecomputer/console/actions/runs/18479011038/job/52649823166#step:8:36

image image

53df521

https://github.com/oxidecomputer/console/actions/runs/18503116960/job/52725077386#step:8:359

image image

@david-crespo
Copy link
Collaborator

david-crespo commented Oct 14, 2025

Yep, we are somehow pulling in the entirety of asciidoctor through the design system.

oxidecomputer/design-system#150

image

@david-crespo
Copy link
Collaborator

david-crespo commented Oct 14, 2025

Confirmed we are back to normal with oxidecomputer/design-system#151. Top is main, bottom is 8996191.

image

@david-crespo
Copy link
Collaborator

Merging as-is with the canary design-system release because I have messed up the releases in the design-system repo real bad. We will update this to stable design-system tomorrow.

@david-crespo david-crespo merged commit 96939d3 into main Oct 15, 2025
11 of 12 checks passed
@david-crespo david-crespo deleted the tailwind-4-new branch October 15, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants