Provide sideModal prop to truncate differently in side modals#3037
Provide sideModal prop to truncate differently in side modals#3037david-crespo merged 7 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Kind of a silly idea, not for this PR: instead of truncating by character, do a CSS truncate with ellipsis so it’s always truncating at the right length, and then use the length as a heuristic to decide whether to show the tooltip on hover. You get some false positives in that you get a tooltip on hover sometimes when you don’t need it, but you never truncate too early. (All of this is moot if there’s a good way to measure the rendered length in JS.) |
In other places we're using the form inputs. I want to refactor this anyway. To be honest I'd expect this to be updatable as a user alongside name.
It gets pretty janky, at least last time I checked. Since you need the font statistics to measure. |
oxidecomputer/console@948c1d3...bf5d6ef * [bf5d6ef9](oxidecomputer/console@bf5d6ef9) oxidecomputer/console#3054 * [924ad0a6](oxidecomputer/console@924ad0a6) oxidecomputer/console#3055 * [9820df40](oxidecomputer/console@9820df40) oxidecomputer/console#3053 * [756faaa7](oxidecomputer/console@756faaa7) oxidecomputer/console#3052 * [cbfd675a](oxidecomputer/console@cbfd675a) oxidecomputer/console#3051 * [4c5e6b3a](oxidecomputer/console@4c5e6b3a) oxidecomputer/console#3050 * [1a10153a](oxidecomputer/console@1a10153a) oxidecomputer/console#3048 * [43a24970](oxidecomputer/console@43a24970) oxidecomputer/console#3046 * [5c3c4074](oxidecomputer/console@5c3c4074) oxidecomputer/console#3045 * [8297880c](oxidecomputer/console@8297880c) oxidecomputer/console#3044 * [986e6dfd](oxidecomputer/console@986e6dfd) oxidecomputer/console#3037 * [0a178bce](oxidecomputer/console@0a178bce) oxidecomputer/console#3043
oxidecomputer/console@948c1d3...bf5d6ef * [bf5d6ef9](oxidecomputer/console@bf5d6ef9) oxidecomputer/console#3054 * [924ad0a6](oxidecomputer/console@924ad0a6) oxidecomputer/console#3055 * [9820df40](oxidecomputer/console@9820df40) oxidecomputer/console#3053 * [756faaa7](oxidecomputer/console@756faaa7) oxidecomputer/console#3052 * [cbfd675a](oxidecomputer/console@cbfd675a) oxidecomputer/console#3051 * [4c5e6b3a](oxidecomputer/console@4c5e6b3a) oxidecomputer/console#3050 * [1a10153a](oxidecomputer/console@1a10153a) oxidecomputer/console#3048 * [43a24970](oxidecomputer/console@43a24970) oxidecomputer/console#3046 * [5c3c4074](oxidecomputer/console@5c3c4074) oxidecomputer/console#3045 * [8297880c](oxidecomputer/console@8297880c) oxidecomputer/console#3044 * [986e6dfd](oxidecomputer/console@986e6dfd) oxidecomputer/console#3037 * [0a178bce](oxidecomputer/console@0a178bce) oxidecomputer/console#3043
oxidecomputer/console@948c1d3...bf5d6ef * [bf5d6ef9](oxidecomputer/console@bf5d6ef9) oxidecomputer/console#3054 * [924ad0a6](oxidecomputer/console@924ad0a6) oxidecomputer/console#3055 * [9820df40](oxidecomputer/console@9820df40) oxidecomputer/console#3053 * [756faaa7](oxidecomputer/console@756faaa7) oxidecomputer/console#3052 * [cbfd675a](oxidecomputer/console@cbfd675a) oxidecomputer/console#3051 * [4c5e6b3a](oxidecomputer/console@4c5e6b3a) oxidecomputer/console#3050 * [1a10153a](oxidecomputer/console@1a10153a) oxidecomputer/console#3048 * [43a24970](oxidecomputer/console@43a24970) oxidecomputer/console#3046 * [5c3c4074](oxidecomputer/console@5c3c4074) oxidecomputer/console#3045 * [8297880c](oxidecomputer/console@8297880c) oxidecomputer/console#3044 * [986e6dfd](oxidecomputer/console@986e6dfd) oxidecomputer/console#3037 * [0a178bce](oxidecomputer/console@0a178bce) oxidecomputer/console#3043



This adds a
sideModalprop to the DescriptionRow that drops the truncation limit from 48 characters to 20, so we better handle the narrower context of a sideModal pane.Broken:

Fixed:

Closes #3034