Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of #3121.
npm run buildis very fast, no more esbuild dependency due to rolldown. The issues breaking the last one are gone — other deps released new versions compatible with Vite 8, and the issue that was breaking the Vercel preview is gone.Only downside is we get about 250 files instead of 100, as discussed in #3121. I don't think this is actually a problem in practice, it just feels silly. I tried using the
codeSplittingsetting to get a better set of chunks, but I couldn't get an overall breakdown I liked better than the default behavior. In #3121 I made a different judgment, but I changed my mind. The issues listed below suggest other people are having the same trouble. These are in a Rolldown milestone with a deadline of May 8, so maybe they will get to it soon.Open rolldown issues around code splitting
[Feature Request]: Add
experimentalMinChunkSizeoption rolldown/rolldown#4932 — Direct request forexperimentalMinChunkSize. The maintainers saycodeSplitting.groupsis the intended tool, but the discussion makes clear it doesn't solve the same problem. The workarounds all produce worse output than just accepting the small chunks.Feature request: a sane strategy/documentation for advancedChunks rolldown/rolldown#7473 — A frustrated Vite 8 user (575 chunks in prod) documenting the same struggle we just went through: every
codeSplittingconfig either breaks execution order, pulls unexpected deps into bundles, or creates one giant blob. Filed as a request for better docs/strategy, still open.[Feature Request]: Apply
minSizethreshold to dynamic import chunks rolldown/rolldown#8707 — Request forminSizeto apply globally (not just within groups), which would give the behavior we want. Closed as "not how minSize is intended to work."Next step for manual code splitting(mcs) rolldown/rolldown#7114 — Tracking issue acknowledging the gaps: need presets/recipes, better
maxSizebehavior, barrel chunk elimination.