Skip to content

Fix NIC e2e test flake in safari #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Apr 23, 2026
Merged

Fix NIC e2e test flake in safari #3198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/e2e/instance-networking.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,13 @@ test('Instance networking tab — NIC table', async ({ page }) => {
await clickRowAction(page, 'my-nic', 'Delete')
await expect(page.getByText('Are you sure you want to delete my-nic?')).toBeVisible()
await page.getByRole('button', { name: 'Confirm' }).click()
await expect(page.getByRole('cell', { name: 'my-nic' })).toBeHidden()
// Wait for the NIC list refetch to land before opening nic-3's menu.
// Otherwise `multipleNics` is still true, Delete renders disabled (wrapped
// in a tooltip), and the unwrap when the refetch lands detaches the
// menuitem and closes the menu on Safari/FF. Row count (vs. checking my-nic
// is gone) because any absence check passes transiently while the confirm
// modal closes and the page is inert.
await expect(nicTable.getByRole('row')).toHaveCount(2) // header + nic-3

// Now the primary NIC is deletable
await clickRowAction(page, 'nic-3', 'Delete')
Expand Down
Loading