Skip to content

minor: delete unused cta prop on Message #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Jun 2, 2026
Merged

minor: delete unused cta prop on Message #3236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 1 addition & 22 deletions app/ui/lib/Message.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,8 @@
*/
import cn from 'classnames'
import type { ReactElement, ReactNode } from 'react'
import { Link, type To } from 'react-router'

import {
Error12Icon,
OpenLink12Icon,
Success12Icon,
Warning12Icon,
} from '@oxide/design-system/icons/react'
import { Error12Icon, Success12Icon, Warning12Icon } from '@oxide/design-system/icons/react'

type Variant = 'success' | 'error' | 'notice' | 'info'

Expand All @@ -23,10 +17,6 @@ export interface MessageProps {
content: ReactNode
className?: string
variant?: Variant
cta?: {
text: string
link: To
}
showIcon?: boolean
}

Expand All @@ -50,7 +40,6 @@ export const Message = ({
content,
className,
variant = 'info',
cta,
showIcon = true,
}: MessageProps) => {
return (
Expand All @@ -73,16 +62,6 @@ export const Message = ({
<div className="text-sans-md text-accent-secondary [&>a]:tint-underline group max-w-3xl">
{content}
</div>

{cta && (
<Link
className="text-sans-md text-accent-secondary hover:text-accent mt-1 flex items-center underline"
to={cta.link}
>
{cta.text}
<OpenLink12Icon className="ml-1" />
</Link>
)}
</div>
</div>
)
Expand Down
Loading