Skip to content

Conversation

@david-crespo
Copy link
Collaborator

@david-crespo david-crespo commented Apr 4, 2022

Closes #705
Closes #771

Doing this in the dumbest way here, leaving out the following things that are in the design:

  • Disk name on snapshots. Want to punt, not sure it makes sense because:
    • the disk may not exist and therefore it has no name
    • even if it does exist, the name may be automatically generated and therefore not recognizable
  • "Disk size" on both, don't think it is meaningful. Both resources have a single size, which is the size that the thing will take up if you make a disk out of it, in other words the minimum size a disk must be to use that image
  • Creation type manual vs. scheduled — we don't have this yet
  • Row select + actions, will do later along with create/edit

Images

image

Snapshots

image

@vercel
Copy link

vercel bot commented Apr 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oxidecomputer/console-ui-storybook/2ygBbcCiiPNEJjTqukzxMig4N3iR
✅ Preview: https://console-ui-storybook-git-snapshots-images-oxidecomputer.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Preview will be deployed at https://console-git-snapshots-images.internal.oxide.computer

@david-crespo david-crespo merged commit aee2fe8 into main Apr 5, 2022
@david-crespo david-crespo deleted the snapshots-images branch April 5, 2022 15:24
@benjaminleonard
Copy link
Contributor

IMO, we will eventually want disk name. Both AWS and GCP do include it, and even if instance is a more readable association, the snapshot and disk are directly related. I'm thinking of linking snapshots with disks, through a link that pre filters snapshots based on a specific disk.

The idea being a user might go into an instance, select the associated disk, then click-through to see the related snapshots. We might even want to populate recent snapshots directly on the single disk view.

@david-crespo
Copy link
Collaborator Author

Going from existing disk to snapshots of that disk is pretty straightforward. I'm not sure what happens after the disk is gone, though. I can certainly imagine wanting to look at snapshots for a disk that no longer exists, but at that point the name is no longer accessible — all we have on each snapshot is the source disk ID. We might need to add some more stuff to the API to support this use case.

@benjaminleonard
Copy link
Contributor

Yeah, though perhaps good to talk how we handle deleted relationships on resources in general. E.g. an image or snapshot has been deleted that was used to create an instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image index Snapshots index

4 participants