-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Milestone
Description
In async fn transfer(..), this unwrap can panic:
let responses = self.downstairs_buffer.remove(ds_id).unwrap();
If (I believe) we have three downstairs that have returned error (not skipped) none of them added
to the downstairs_buffer, and we get the unwrap() panic.
Update the code to better check for errors and if so, don't panic.
If at least one of the reads did succeed, and we should have a buffer, then we probably should
panic as that would mean something in crucible has lost the buffer and returning success to
the guest without giving them that buffer would be data corruption and we can't have that.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Give feedbackNo fields configured for issues without a type.