Make Buffer track per-block (not per-byte) ownership#1091
Closed
mkeeter wants to merge 6 commits intooxidecomputer:mainfrom
Closed
Make Buffer track per-block (not per-byte) ownership#1091mkeeter wants to merge 6 commits intooxidecomputer:mainfrom
mkeeter wants to merge 6 commits intooxidecomputer:mainfrom
Conversation
Contributor
Author
|
Re-running on Crucible |
Contributor
Author
|
(let's put this on hold until #1094, which touches a bunch of similar code) |
Contributor
Author
|
Closing in favor of #1105, since this has diverged from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces storage (and operations) in the
struct Bufferby the block size, so a factor of 512× or 4096×.The downside is that we need to know the block size at construction time, so there's a bunch of mechanical changes in this PR.
I see significant speedups for all sizes of random reads except 4K, which become slightly slower (50.6 MiB/s → 46.9 MiB/s, not sure why).