Remove bonus Volume layer#1927
Conversation
`Volume::construct` was unintentionally adding another layer of Volume when constructing from a request. Remove this, ensuring that what is constructed matches the request.
leftwo
left a comment
leftwo
left a comment
There was a problem hiding this comment.
I assume (as tests pass) that the volume replacement stuff can still handle and we did not accidentally require multiple volume layers to make things work?
Also, this should not impact what Omicron has in the json blob for a VCR, right?
If anything it's a testament to our code quality that the replacement code worked before and after this change :) I have the same fear here too, but will also trust the tests here.
I also had this same fear, but no: the request that's stored in the database doesn't change or need to change here. It's |
| } | ||
| } | ||
|
|
||
| fn to_arc_block_io<T>(b: T) -> Arc<dyn BlockIO + Send + Sync> |
There was a problem hiding this comment.
I'm mad that this is necessary (and that we can't use Arc::new or .from() directly), but haven't found a way to avoid it.
| (guest, io) | ||
| } | ||
|
|
||
| pub async fn create_and_up_main( |
There was a problem hiding this comment.
This function doesn't need async (clippy complains in my editor, dunno why it passes in CI)
|
I spun up the Canada region and performed a bunch of replacements, so we're good here. Going to merge! |
3 participants
Volume::constructwas unintentionally adding another layer of Volume when constructing from a request. Remove this, ensuring that what is constructed matches the request.