move asic-specific features into api trait#140
Merged
rcgoodfellow merged 1 commit intomainfrom Sep 27, 2025
Merged
Conversation
sunshowers
approved these changes
Sep 26, 2025
Comment on lines
+2274
to
+2280
| /// The switch port ID. | ||
| pub port_id: PortId, | ||
| /// The link ID. | ||
| pub link_id: LinkId, | ||
| /// The FEC counter data. | ||
| pub counters: FecRSCounters, | ||
| } |
Contributor
There was a problem hiding this comment.
You may want to put these in dpd-types, especially if they're going to be replaced in the future.
rcgoodfellow
force-pushed
the
ry/finish-trait-migration
branch
from
1fc43a9 to
29efa40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves remaining API methods into the API trait so the API manager can be used.
Implementations of these methods are gated by asic features similar to how inclusion of these methods in the API document was gated by asic features before.