[multicast] wire up softnpu backend to multicast table ops#242
Merged
zeeshanlakhani merged 3 commits intomulticast-e2efrom Apr 28, 2026
Merged
[multicast] wire up softnpu backend to multicast table ops#242zeeshanlakhani merged 3 commits intomulticast-e2efrom
zeeshanlakhani merged 3 commits intomulticast-e2efrom
Conversation
zeeshanlakhani
force-pushed
the
zl/softnpu-with-mcast
branch
from
a3f94ef to
abf35dd
Compare
zeeshanlakhani
changed the title
zeeshanlakhani
requested review from
FelixMcFelix,
Nieuwejaar,
rcgoodfellow and
taspelund
zeeshanlakhani
force-pushed
the
zl/softnpu-with-mcast
branch
from
594dd68 to
abf35dd
Compare
This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50)
zeeshanlakhani
force-pushed
the
zl/softnpu-with-mcast
branch
from
abf35dd to
b586dfd
Compare
zeeshanlakhani
force-pushed
the
zl/softnpu-with-mcast
branch
2 times, most recently
from
3f64f2d to
8c60a82
Compare
…ce list `modify_group_external` wrote back `new.sources.or(existing)` to the in-memory record while `update_external_tables` in the same call canonicalized `new.sources` directly to rewrite the P4 source-filter entries. A `None` update therefore cleared the P4 table but left a stale `Some([...])` in memory.
zeeshanlakhani
force-pushed
the
zl/softnpu-with-mcast
branch
from
8c60a82 to
a8701ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline.
AsicMulticastOps
We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern.
Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width.
Table translation (asic/src/softnpu/table.rs)
We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation.
All multicast action arms are gated with
#[cfg(feature = "multicast")].References