Split /components export into /asciidoc and /ui
#151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-crespo
had a problem deploying
to
production
GitHub Actions
Failure
benjaminleonard
temporarily deployed
to
production
GitHub Actions
Inactive
david-crespo
requested a deployment
to
production
GitHub Actions
Waiting
benjaminleonard
temporarily deployed
to
production
GitHub Actions
Inactive
david-crespo
temporarily deployed
to
production
GitHub Actions
Inactive
david-crespo
temporarily deployed
to
production
GitHub Actions
Inactive
david-crespo
changed the title
/components export into /asciidoc and /ui
david-crespo
commented
Oct 14, 2025
package.json
Outdated
| "typings": "./dist/components/index.d.ts", | ||
| "module": "./dist/components/index.js", | ||
| "typings": "./dist/components/src/asciidoc/index.d.ts", | ||
| "module": "./dist/components/src/asciidoc/index.js", |
There was a problem hiding this comment.
This is kind of janky since there isn't really one thing for the whole library. Same problem with the . thing below — it means import '@oxide/design-system' gets you asciidoc. I guess that's fine? Can we leave that dot out and just make it so you can't import the library without a path like that?
There was a problem hiding this comment.
Fixed it by deleting it. Unqualified import is rejected by both TS and build as expected.
david-crespo
temporarily deployed
to
production
GitHub Actions
Inactive
david-crespo
added
major
9 tasks
|
Confirmed this fixes the problem: oxidecomputer/console#2910 (comment) |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150
Calling it a minor version because it adds a new export but shouldn't break anything existing.
📦 Published PR as canary version:
4.0.0--canary.151.18511380774.0✨ Test out this PR locally via:
npm install @oxide/design-system@4.0.0--canary.151.18511380774.0 # or yarn add @oxide/design-system@4.0.0--canary.151.18511380774.0