New approach to wide gamut colour #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.1...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
benjaminleonard
added
major
…n5-2.2.3 Bump json5 from 2.2.1 to 2.2.3
…ver-5.7.2 Bump semver from 5.7.1 to 5.7.2
…d-wrap-1.2.4 Bump word-wrap from 1.2.3 to 1.2.4
Provides more flexibility for color edge cases
benjaminleonard
added
major
|
Figured as we launch 1.0.0 of the rack that now is a good time to do the same on the design system. Included a few other fixes in here, grabbed the latest icons and did a rebuild. There's probably work that can be done on neatening up the logic in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous approaches to P3 colour were slightly janky postcss plugins that would read the hex value, convert to rgb and extra an extra colour value. Unfortunately this does not work with variables because you don't have the value to make that calculation.
I tried another approach here: oxidecomputer/console#1364
Unfortunately that came with its own issues, namely it does not support theming, adds a bunch of extra stuff in the classes and relies on some brittle postcss work.
Here we're generating the
p3var alongside thergbone. We can then use the@supportscss rule to check fordisplay-p3support and if that's present include the colour.Last piece to check off is to make sure that colours with an alpha value work okay.
📦 Published PR as canary version:
1.0.0--canary.38.a11788c.0✨ Test out this PR locally via:
npm install @oxide/design-system@1.0.0--canary.38.a11788c.0 # or yarn add @oxide/design-system@1.0.0--canary.38.a11788c.0