verifier: add sled-agent implementation for Attest#347
Merged
Conversation
flihp
approved these changes
Jan 29, 2026
Collaborator
flihp
left a comment
flihp
left a comment
There was a problem hiding this comment.
The two unwraps make me a bit itchy but on the whole this is excellent. Thank you!
labbott
approved these changes
Jan 29, 2026
Contributor
labbott
left a comment
labbott
left a comment
There was a problem hiding this comment.
This is super helpful to me as well
luqmana
force-pushed
the
sled-agent-attest
branch
2 times, most recently
from
43855e8 to
7155884
Compare
luqmana
force-pushed
the
sled-agent-attest
branch
from
7155884 to
8794878
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new
dice_verifier::Attestimpl that uses the sled-agent APIs (oxidecomputer/omicron#9739) to make the necessary RoT calls.