Skip to content

fix a few typos#359

Merged
iximeow merged 1 commit intomainfrom
typos
Mar 30, 2026
Merged

fix a few typos#359
iximeow merged 1 commit intomainfrom
typos

Conversation

@iximeow
Copy link
Copy Markdown
Member

@iximeow iximeow commented Mar 24, 2026

super tiny stuff, @flihp I'd mentioned I was reading through dice-util and this is all that'd really caught my eye!

Comment thread verifier/src/lib.rs
Comment on lines +560 to +563
#[error(
"Alias public key is malformed: \
spki bit string does not end on octet boundary"
)]
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my read of https://docs.rs/der/0.7.10/der/asn1/struct.BitString.html#method.as_bytes it looks like this is a more accurate description of what this variant indicates. seems reasonable to expect either way, I dunno a valid reason to see OddKey typically..

Copy link
Copy Markdown
Collaborator

@flihp flihp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iximeow iximeow merged commit deab8e3 into main Mar 30, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants