[7/7] add multi-element oneOf/anyOf/allOf tests#10
Merged
sunshowers merged 4 commits intomainfrom Feb 2, 2026
Merged
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
ahl
approved these changes
Feb 2, 2026
Collaborator
ahl
left a comment
ahl
left a comment
There was a problem hiding this comment.
Does this PR add additional validation or just simplify the validation that was already there? (and test it)
| Ok(ret) | ||
| } | ||
|
|
||
| // NOTE: Single-element allOf schemas are flattened by `try_compare_flattened` |
Collaborator
There was a problem hiding this comment.
was this something we just missed when introducing try_compare_flattened?
| self.schema_push_change( | ||
| dry_run, | ||
| "integer schema changed", | ||
| "boolean schema changed", |
Contributor
Author
There was a problem hiding this comment.
Added a test for this.
Contributor
Author
Just simplifies existing validation. Though there's one case that is now handled better: allOf with multiple schemas where the contents on both sides are identical. |
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
sunshowers
changed the base branch from
sunshowers/spr/main.77-add-multi-element-oneofanyofallof-tests
to
main
sunshowers
deleted the
sunshowers/spr/77-add-multi-element-oneofanyofallof-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add /anyof and /allof endpoints and tests for multi-element composite schema changes. Simplify
compare_schema_type_all_ofto use equality check like anyOf. Fix bug where boolean schema changes reported as "integer schema changed".