add ClientSpecifiesVersionInHeader::on_missing #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
davepacheco
reviewed
Nov 15, 2025
Collaborator
davepacheco
left a comment
davepacheco
left a comment
There was a problem hiding this comment.
Looks good aside from the one comment request. Can you update the CHANGELOG as well?
| ClientSpecifiesVersionInHeader { name, max_version, on_missing: None } | ||
| } | ||
|
|
||
| /// If the header is missing, use the provided version instead. |
Collaborator
There was a problem hiding this comment.
Can we update this comment to dissuade people from using this if they control the clients (and maybe explicitly say not for Oxide internal services?)
Contributor
Author
There was a problem hiding this comment.
Done, and bolded.
davepacheco
approved these changes
Nov 18, 2025
davepacheco
deleted the
sunshowers/spr/add-clientspecifiesversioninheaderon_missing
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow substituting a version if the header is missing. We're going to use this policy for the Nexus external API.