Skip to content

Conversation

@rcgoodfellow
Copy link
Collaborator

This PR adds automatic management of propolis and ovmf binaries.

When a topology is launched, falcon will check for propolis and ovmf binaries in the local falcon topology directory (.falcon unless overridden). In the case that the propolis-server binary is overridden by the user, no attempt is made to manage the overridden binary.

Fixes:

Improves the situation the following since binaries are now local instead of in /var and /usr/bin.

@rcgoodfellow
Copy link
Collaborator Author

rcgoodfellow commented Apr 14, 2025

Output from test run

ry@masaka:~/labs/duo$ pfexec ./duo launch
Apr 14 18:59:46.908 INFO propolis-server digest '99d55ec1af0c7e6d62311fbf7020b721fbf6308785af852ef99feed1a64649a4' does not match expected '183e5a0bd6047f08e28e46de58b9f62dee7bc708bebac77747ac94942f49bf1d'
Apr 14 18:59:46.908 INFO downloading propolis server rev 02fdf06bb279fc1b1393f993b90cbe84b7e9f281
[00:00:19] ######################################## 62.03 MiB/62.03 MiB
Apr 14 19:00:07.168 INFO creating links
Apr 14 19:00:07.168 INFO creating simnet link 'duo_violin_vn_sim0'
Apr 14 19:00:07.173 INFO creating vnic link 'duo_violin_vn_vnic0'
Apr 14 19:00:07.190 INFO creating simnet link 'duo_piano_vn_sim0'
Apr 14 19:00:07.192 INFO creating vnic link 'duo_piano_vn_vnic0'
Apr 14 19:00:07.208 INFO creating external links
Apr 14 19:00:07.208 INFO creating external link duo_violin_vn_vnic1
Apr 14 19:00:07.209 INFO creating external link duo_piano_vn_vnic1
Apr 14 19:00:07.210 INFO creating nodes
Apr 14 19:00:07.241 INFO launched instance violin with pid 6342 on port 34139
Apr 14 19:00:07.241 INFO instance ensure: violin
Apr 14 19:00:07.253 INFO launched instance piano with pid 6343 on port 39546
Apr 14 19:00:07.253 INFO instance ensure: piano
Apr 14 19:00:09.198 INFO instance run: violin
Apr 14 19:00:09.234 INFO instance run: piano
Apr 14 19:01:24.266 INFO piano: mounting /opt/cargo-bay
Apr 14 19:01:24.311 INFO piano: finished mounting /opt/cargo-bay
Apr 14 19:01:24.353 INFO violin: mounting /opt/cargo-bay
Apr 14 19:01:24.353 INFO piano: logging out
Apr 14 19:01:24.374 INFO violin: finished mounting /opt/cargo-bay
Apr 14 19:01:24.418 INFO violin: logging out
Apr 14 19:01:25.566 INFO piano: logged out
Apr 14 19:01:25.788 INFO violin: logged out

Copy link
Contributor

@elaine-oxide elaine-oxide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

Copy link
Contributor

@elaine-oxide elaine-oxide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All items from my last review have been resolved. Thank you!

@rcgoodfellow rcgoodfellow merged commit 8410685 into main Apr 16, 2025
2 checks passed
@rcgoodfellow rcgoodfellow deleted the issue138 branch April 16, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

better propolis server management. Runner should ensure propolis binary corresponds to propolis client lib falcon is compiled against

3 participants