-
Notifications
You must be signed in to change notification settings - Fork 5
Automatic propolis and ovmf management #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f1a71ee
automatic propolis-server binary management
rcgoodfellow 0f1a17e
add automatic ovmf management
rcgoodfellow a8129fb
move to mainline propolis, various cleanup
rcgoodfellow 8ef1015
move to propolis main, cleanup
rcgoodfellow c740e3a
review feedback
rcgoodfellow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| //! This file generates a rust file with a single constant in it, | ||
| //! PROPOLIS_REV, that holds the git revision of propolis that | ||
| //! this build expects. The expected revision is pulled from | ||
| //! the workspace Cargo.toml. This constant is used to automatically | ||
| //! download propolis from buildomat CI artifacts as a part of | ||
| //! the topology preflight process, ensuring that the propolis binary | ||
| //! we use matches the propolis API revision falcon was built against. | ||
|
|
||
| use cargo_toml::Manifest; | ||
| use quote::quote; | ||
| use std::env; | ||
| use std::fs; | ||
| use std::path::Path; | ||
|
|
||
| fn main() { | ||
| get_propolis_version(); | ||
| } | ||
|
|
||
| fn get_propolis_version() { | ||
| let manifest = Manifest::from_path("../Cargo.toml") | ||
| .expect("read workspace Cargo.toml"); | ||
|
|
||
| let workspace = manifest.workspace.expect("get workspace"); | ||
|
|
||
| let propolis = workspace | ||
| .dependencies | ||
| .get("propolis-client") | ||
| .expect("build.rs: get propolis client dependency"); | ||
|
|
||
| let Some(rev) = propolis.git_rev() else { | ||
| panic!("build.rs: expected git rev for propolis client"); | ||
| }; | ||
|
|
||
| let out_dir = env::var_os("OUT_DIR").unwrap(); | ||
| let dest_path = Path::new(&out_dir).join("propolis_version.rs"); | ||
|
|
||
| let tokens = quote! { const PROPOLIS_REV: &str = #rev; }; | ||
|
|
||
| let file: syn::File = | ||
| syn::parse2(tokens).expect("build.rs: parse generated code"); | ||
| let code = prettyplease::unparse(&file); | ||
|
|
||
| fs::write(&dest_path, code).unwrap(); | ||
rcgoodfellow marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| println!("cargo::rerun-if-changed=../Cargo.toml"); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.