Make array of commands static#249
Closed
daniel-levin wants to merge 1 commit intooxidecomputer:masterfrom
Closed
Conversation
jclulow
reviewed
Apr 21, 2026
Collaborator
jclulow
left a comment
There was a problem hiding this comment.
Can name and desc just be a &static str in that case?
Author
|
Indeed, they can and it'd make sense for them to be! |
Author
|
Force pushed an update with this change and the associated removals of allocations. struct CommandInfo {
- name: String,
- desc: String,
+ name: &'static str,
+ desc: &'static str |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor non-functional change - I noticed there were was a
VecofCommandInfos where a static array would do fine.