Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did an experiment where Hubris builds were isolated by image + task, which made incremental rebuilds much faster (45 → 11 seconds) but take up much more space (1 GiB → 23 GiB). This PR doesn't implement that change, but it does lay the groundwork for that (or similar) changes by abstracting away a per-task working directory. Now, instead of being hard-coded to
target, the build system has to ask thePackageConfigfor a working directory (passing in the task name as an argument). Right now, we always returntarget, so there should be no functional change.In many cases, passing around the whole
&PackageConfigas an argument makes other arguments unnecessary (because they were being extracted out of thePackageConfig.