Make sure we're muxed to the SP before setting the mux to the host#2457
Merged
Make sure we're muxed to the SP before setting the mux to the host#2457
Conversation
labbott
reviewed
Mar 27, 2026
Collaborator
labbott
left a comment
There was a problem hiding this comment.
Was this issue always present or did the APOB version pinning make this show up?
Collaborator
Author
|
I think it's always been present – even before APOB pinning, we'd call |
labbott
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the SP hangs if you call
set_mux(HostCPU)twice in a row. This is because the first call switches the mux from the SP to the host; the second call tries to read from flash while it's muxed to the host (to find the APOB, ABL0 version, etc). When the flash is muxed to the host, the FPGA never loads bytes into the SP's FIFO, so this hangs thehftask forever.