Conversation
jgallagher
force-pushed
the
use-workspace-dependencies
branch
from
05a1d50 to
d9121cf
Compare
bcantrill
pushed a commit
that referenced
this pull request
Jun 22, 2023
Bumps Rust toolchain to 1.65
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes all of humility's dependencies to reference top-level workspace dependencies. I believe all of these changes are safe (with the primary evidence being the lack of changes to
Cargo.lock, except for intentionally removing an unnecessary dependency onserde_derive), but maybe that's not 100% guaranteed in terms of cargo features? I'm not sure they would necessarily show up inCargo.lockif I missed something there.There's one hitch: top-level humility renames all of the
humility-cmd-xyzto justcmd-xyz, but there are a handful of commands that reference other commands, and they were using the longer names with thehumility-prefix. I can't figure out how to make this work without changing one or the other: the workspace dependency docs say the only flags that can be combined withworkspace = trueareoptionalandfeatures, and true to that statement, addingpackage = blahto try to rename them does not work. I settled with adding a rename import to the handful of commands that needed this, but am open to other suggestions.