Duplicate type definitions cause hiffy failures#294
Merged
Conversation
Instead of doing the right thing and deep comparing the types of struct members, we only compare their offset and name (yikes!). Do not merge, but in limited cases this branch may be useful until #233 is fixed for real.
mkeeter
reviewed
Dec 15, 2022
mkeeter
reviewed
Dec 15, 2022
mkeeter
reviewed
Dec 15, 2022
mkeeter
reviewed
Dec 15, 2022
mkeeter
reviewed
Dec 15, 2022
mkeeter
reviewed
Dec 15, 2022
mkeeter
reviewed
Dec 15, 2022
mkeeter
reviewed
Dec 15, 2022
mkeeter
approved these changes
Dec 15, 2022
bcantrill
added a commit
that referenced
this pull request
Jun 22, 2023
This fixes #233, and also allows "humility hiffy --list" to be run postmortem, allowing for much better testing. This work also changes the format of "humility hiffy --list" to be more readable in the presence of long operation names, long argument names, and long argument type names. Co-authored-by: John Gallagher <john@oxidecomputer.com> Co-authored-by: Matt Keeter <matt@oxide.computer>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft commit message: