Conversation
Contributor
Author
|
I realized I hadn't run |
Contributor
Author
|
Squashed the formatting changes in 💪 |
I tried to stick to preserving semantics as much as possible, even if altneratives might be shorter. The transformations: * bail! -> Err(anyhow! * return err! -> bail! * if ... err! -> ensure!
bcantrill
approved these changes
Jul 13, 2020
Contributor
bcantrill
left a comment
bcantrill
left a comment
There was a problem hiding this comment.
This looks great -- <3 anyhow! Thanks for doing this and showing the way!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add a .gitignore
More principled than #3, and included @jclulow 's feedback from that PR too :)