Conversation
mkeeter
requested review from
bcantrill,
cbiffle,
hawkw,
jgallagher and
labbott
hawkw
reviewed
Aug 8, 2025
Member
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
There are some new Clippy warnings on CI in a few files that don't seem to be failing the check. Just thought I'd point those out. Otherwise, this seems good to me.
Member
There was a problem hiding this comment.
There are some Clippy warnings in here about hidden elided lifetimes, but they don't seem to be making the check fail: https://github.com/oxidecomputer/humility/actions/runs/16838991454/job/47705335164?pr=556#step:6:733
| bail!("bad symbol in {}: {}", object, sym.st_name); | ||
| } | ||
| let Some(name) = elf.strtab.get_at(sym.st_name) else { | ||
| bail!("bad symbol in {}: {}", object, sym.st_name); |
Member
There was a problem hiding this comment.
nit, take it or leave it:
Suggested change
| bail!("bad symbol in {}: {}", object, sym.st_name); | |
| bail!("bad symbol in {object}: {}",, sym.st_name); |
Contributor
Author
There was a problem hiding this comment.
I think I'll punt on this, since even Clippy 1.88 doesn't complain about it (because sym.st_name can't be inlined)
hawkw
approved these changes
Aug 11, 2025
mkeeter
force-pushed
the
mkeeter/bump-deps
branch
from
4f42dfa to
a00701b
Compare
mkeeter
force-pushed
the
mkeeter/bump-deps
branch
from
a00701b to
b6ee1b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a dependency bump for better backtraces (in a subsequent PR), as well as switching to Rust 2024 and bumping the MSRV.