Move hiffy_call into a method on HiffyContext#682
Merged
Conversation
hawkw
reviewed
May 26, 2026
| } | ||
|
|
||
| /// Executes a Hiffy call, returning the output value (or an error) | ||
| pub fn call<T: humility::reflect::Load>( |
Member
There was a problem hiding this comment.
i kinda wonder if this ought to still be named
Suggested change
| pub fn call<T: humility::reflect::Load>( | |
| pub fn hiffy_call<T: humility::reflect::Load>( |
since all the call sites for it basically look like context.call(...) which doesn't make it clear that it's hiffy. i realize that the type is called HiffyContext, but the references to
Contributor
Author
There was a problem hiding this comment.
but the references to
RIP Eliza, eaten by a grue mid-comment 🪦
(I'm going to keep this as call, since like you said it's a method on a HiffyContext)
mkeeter
force-pushed
the
mkeeter/validate-decode
branch
from
7d6dd7d to
10fae77
Compare
mkeeter
force-pushed
the
mkeeter/hiffy-call-method
branch
2 times, most recently
from
06762af to
9bef9ab
Compare
mkeeter
force-pushed
the
mkeeter/validate-decode
branch
2 times, most recently
from
ea0665f to
5e045a6
Compare
mkeeter
force-pushed
the
mkeeter/hiffy-call-method
branch
from
9bef9ab to
5004e39
Compare
labbott
reviewed
May 27, 2026
Contributor
labbott
left a comment
labbott
left a comment
There was a problem hiding this comment.
LGTM I have no opinion on naming here
mkeeter
force-pushed
the
mkeeter/validate-decode
branch
from
5e045a6 to
48e0910
Compare
mkeeter
force-pushed
the
mkeeter/hiffy-call-method
branch
from
5004e39 to
11943a3
Compare
hawkw
approved these changes
May 27, 2026
Member
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
i also don't feel strongly about the naming thing
mkeeter
force-pushed
the
mkeeter/hiffy-call-method
branch
from
11943a3 to
6b30409
Compare
mkeeter
force-pushed
the
mkeeter/validate-decode
branch
2 times, most recently
from
46c2356 to
bb36316
Compare
mkeeter
force-pushed
the
mkeeter/hiffy-call-method
branch
2 times, most recently
from
1bdb2f7 to
bf11d08
Compare
mkeeter
force-pushed
the
mkeeter/validate-decode
branch
2 times, most recently
from
b57375b to
db92a47
Compare
mkeeter
force-pushed
the
mkeeter/hiffy-call-method
branch
2 times, most recently
from
9b94c7a to
f6196a5
Compare
mkeeter
force-pushed
the
mkeeter/validate-decode
branch
2 times, most recently
from
961db36 to
51cf51f
Compare
mkeeter
force-pushed
the
mkeeter/hiffy-call-method
branch
from
f6196a5 to
40a3fb8
Compare
mkeeter
force-pushed
the
mkeeter/validate-decode
branch
from
51cf51f to
871e7ec
Compare
mkeeter
force-pushed
the
mkeeter/hiffy-call-method
branch
from
40a3fb8 to
418aa09
Compare
mkeeter
force-pushed
the
mkeeter/hiffy-call-method
branch
from
418aa09 to
bc6d425
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Staged on #681)
This is a small simplification PR to make
hiffy_callinto a method onHiffyContext, since that's the type which clearly "owns" the behavior.