the dependency exists to re-export Crucible types:
|
pub use propolis_client::{CrucibleOpts, VolumeConstructionRequest}; |
it seems to me that we should either:
- type the
CrucibleOpts parts of propolis-server's API as an opaque string or something, if the type should be fully opaque to Propolis (as I think VolmueConstructionRequest is?), or
- actually provide the Crucible type as part of
propolis-api-types in an explicit admission that the item from Crucible is necessary as part of propolis-server's HTTP API.
because this dependency exists, it complicates ls-apis and requires some extra API exclusion rules in api-manifest.toml. it'll be really nice to clean up the propolis-client-related rules there once we've untangled this.
the dependency exists to re-export Crucible types:
omicron/clients/sled-agent-client/src/lib.rs
Line 15 in b845b31
it seems to me that we should either:
CrucibleOptsparts ofpropolis-server's API as an opaquestringor something, if the type should be fully opaque to Propolis (as I thinkVolmueConstructionRequestis?), orpropolis-api-typesin an explicit admission that the item from Crucible is necessary as part ofpropolis-server's HTTP API.because this dependency exists, it complicates
ls-apisand requires some extra API exclusion rules inapi-manifest.toml. it'll be really nice to clean up thepropolis-client-related rules there once we've untangled this.