[sled-hardware-types] Move I/O logic out of types crate#10028
Merged
Conversation
smklein
reviewed
Mar 11, 2026
smklein
reviewed
Mar 11, 2026
mergeconflict
force-pushed
the
mergeconflict/move-underlay-bootstrap-ip
branch
from
48b993a to
28c00cc
Compare
sled-hardware-types depended on illumos-utils and omicron-common solely because BootstrapInterface::ip() performed async I/O via Dladm::get_mac(). This is inappropriate for a types crate and pulls in heavyweight dependencies for consumers that only need the type definitions (e.g. ddm-admin-client, wicketd). Extract ip() as a free function bootstrap_ip() in sled-hardware::underlay, which already has these dependencies. The pure types (BootstrapInterface, BOOTSTRAP_PREFIX, BOOTSTRAP_MASK) remain in sled-hardware-types.
mergeconflict
force-pushed
the
mergeconflict/move-underlay-bootstrap-ip
branch
from
28c00cc to
5387052
Compare
smklein
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sled-hardware-types depended on illumos-utils and omicron-common because
BootstrapInterface::ip()performed I/O viaDladm::get_mac(). We don't really want those dependencies here, particularly for downstream crates that only need the type definitions (e.g. ddm-admin-client, wicketd).Extract
BoostrapInterface::ip()as a free functionbootstrap_ip()in sled-hardware::underlay, which already depends on illumos-utils and omicron-common.BootstrapInterface,BOOTSTRAP_PREFIXandBOOTSTRAP_MASKremain in sled-hardware-types.