Guest VMs should get vsock devices by default#10037
Open
papertigers wants to merge 1 commit intomainfrom
Open
Conversation
Created using jj-spr 0.1.0
papertigers
commented
Mar 11, 2026
Comment on lines
+701
to
+705
| bhyve_api = { git = "https://github.com/oxidecomputer/propolis", rev = "19c5faa556ebab465ac6cf42a133125c41b9e2c5" } | ||
| propolis-api-types-versions = { git = "https://github.com/oxidecomputer/propolis", rev = "19c5faa556ebab465ac6cf42a133125c41b9e2c5" } | ||
| propolis_api_types = { git = "https://github.com/oxidecomputer/propolis", rev = "19c5faa556ebab465ac6cf42a133125c41b9e2c5" } | ||
| propolis-client = { git = "https://github.com/oxidecomputer/propolis", rev = "19c5faa556ebab465ac6cf42a133125c41b9e2c5" } | ||
| propolis-mock-server = { git = "https://github.com/oxidecomputer/propolis", rev = "19c5faa556ebab465ac6cf42a133125c41b9e2c5" } |
Contributor
Author
There was a problem hiding this comment.
These git hashes need to be updated to match the actual commit that lands in propolis before we land this.
| source.type = "prebuilt" | ||
| source.repo = "propolis" | ||
| source.commit = "36f20be9bb4c3b362029237f5feb6377c982395f" | ||
| source.commit = "19c5faa556ebab465ac6cf42a133125c41b9e2c5" |
Contributor
Author
There was a problem hiding this comment.
This commit and sha256 also needs to be updated before we land this commit.
| component_names::VSOCK, | ||
| Component::VirtioSocket(VirtioSocket { | ||
| guest_cid: VSOCK_GUEST_CID, | ||
| pci_path: PciPath { bus: 0, device: 0x19, function: 0 }, |
Contributor
Author
There was a problem hiding this comment.
We need to pick a real BDF for vsock before this lands. This value is here just to allow me to test things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Oxide VMs should get a vsock device by default that gives the guest access to the vm attestation socket server as defined in RFD 605.
Fixes: #10000