Address post-merge feedback from #10075.#10141
Merged
mergeconflict merged 2 commits intomainfrom Mar 24, 2026
Merged
Conversation
hawkw
approved these changes
Mar 24, 2026
| //! | ||
| //! ```text | ||
| //! // in nexus-db-schema | ||
| //! ```rust,ignore |
Member
There was a problem hiding this comment.
it would be nice if this didn't have to say ignore on it; which I think would basically just require us to import some stuff. we would probably have to chop off the crate::enums types at the end and add a // ... there, though.
Comment on lines
+9
to
+16
| //! Almost all database queries in this crate are defined as methods on | ||
| //! [`DataStore`], so everything is called as `datastore.method()` rather than | ||
| //! being namespaced in a module. Because of this, methods follow a naming | ||
| //! convention with the resource/object name _first_, followed by the verb: | ||
| //! `disk_list` rather than `list_disks`, `instance_fetch` rather than | ||
| //! `fetch_instance`, and so on. This reads less like natural English but makes | ||
| //! it easy to find all operations on a given resource by searching for the | ||
| //! prefix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.