omdb: Fix component details error in 'mgs sensors'#10190
Merged
wfchandler merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
In ac4ec36 (Update `gateway-messages` and bundled `faux-mgs` (#9354), 2025-11-06), we added component details types that don't support being converted into a measurement. As a result, `omdb mgs sensors` will fail to load any data, instead printing this for each sled: failed to read devices for SpIdentifier { slot: 2, type_: Sled }: Error Response: status: 400 Bad Request; value: Error { error_code: None, message: "requested component details are not yet supported: unsupported component details: last post code: LastPostCode(3993043480)" } Add an error code to `UnsupportedComponentDetails` so clients can reliably identify these failures, and filter them out in the `sensors` subcommand.
jgallagher
approved these changes
Mar 30, 2026
Contributor
jgallagher
left a comment
jgallagher
left a comment
There was a problem hiding this comment.
Thanks, nice workaround.
Do you mind filing an issue that we should update SpComponentDetails to account for the new types (pending either a fix for #9708 or conditional on pinning sled-agent to MGS API 1.0.0)?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #9354, we added component details types that don't support being converted into a measurement. As a result,
omdb mgs sensorswill fail to load any data, instead printing this for each sled:Add an error code to
UnsupportedComponentDetailsso clients can reliably identify these failures, and filter them out in thesensorssubcommand.