fix test flake: use db precision timestamps for test_audit_log_basic#10276
Merged
david-crespo merged 2 commits intomainfrom Apr 16, 2026
Merged
fix test flake: use db precision timestamps for test_audit_log_basic#10276david-crespo merged 2 commits intomainfrom
david-crespo merged 2 commits intomainfrom
Conversation
iliana
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10274
test_audit_log_basictakesUtc::now()timestamps before and after DB operations and asserts that the timestamp on the audit log entry falls between them. ButUtc::now()has nanosecond precision and CockroachDB truncates to microseconds, so ift1is19:16:44.154913040and the audit log entry was written at.154913999, the value read back from the DB would be19:16:44.154913, which is beforet1. Usenow_db_precision()so the test timestamps have the same precision as the DB. The comparisons were alreadyt1 <= log_time, so they will work if they're equal.