Merged
Conversation
Fixes a possible deadlock in the OPTE port manager. When failing to add external IPs for a new port, we both the `PortTicket` and a lock guard around the mananger's mapping of all ports. Unforunately, we do that in the wrong order: `PortTicket` first, which attempts to take that same lock in its drop implementation. This drops the port lock earlier, to avoid a deadlock. Fixes #10280
jgallagher
reviewed
Apr 16, 2026
jgallagher
approved these changes
Apr 16, 2026
FelixMcFelix
approved these changes
Apr 16, 2026
Contributor
FelixMcFelix
left a comment
FelixMcFelix
left a comment
There was a problem hiding this comment.
Looks good; thanks for the quick turnaround!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a possible deadlock in the OPTE port manager. When failing to add external IPs for a new port, we both the
PortTicketand a lock guard around the mananger's mapping of all ports. Unforunately, we do that in the wrong order:PortTicketfirst, which attempts to take that same lock in its drop implementation. This drops the port lock earlier, to avoid a deadlock.Fixes #10280